Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python311Packages.pot: pypi missing files, switch to github; fixbuild #270851

Merged
merged 1 commit into from Nov 29, 2023
Merged

python311Packages.pot: pypi missing files, switch to github; fixbuild #270851

merged 1 commit into from Nov 29, 2023

Conversation

ghost
Copy link

@ghost ghost commented Nov 29, 2023

pypi source is missing tests/conftest.py which is causing the tests to fail with missing attribute errors. with the correct files can now enable many of the previously disabled tests.

ZHF: #265948
https://hydra.nixos.org/build/242353308

Result of nixpkgs-review run on x86_64-linux 1

4 packages built:
  • python310Packages.pot
  • python310Packages.pot.dist
  • python311Packages.pot
  • python311Packages.pot.dist

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

pypi source is missing tests/conftest.py which is causing the tests to
with missing attribute errors
@yl3dy
Copy link
Contributor

yl3dy commented Nov 29, 2023

Result of nixpkgs-review pr 270851 run on x86_64-linux 1

4 packages built:
  • python310Packages.pot
  • python310Packages.pot.dist
  • python311Packages.pot
  • python311Packages.pot.dist

Copy link
Contributor

@yl3dy yl3dy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@delroth delroth added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Nov 29, 2023
@emilytrau emilytrau merged commit b649a06 into NixOS:master Nov 29, 2023
28 of 29 checks passed
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants